9 Commits

Author SHA1 Message Date
b016d58d84 chore: bump version to v0.5.7 2025-08-20 11:10:20 +02:00
6232e91925 feat: layout filters horizontally 2025-08-20 11:10:06 +02:00
7ce4fbd756 chore: bump version to v0.5.6 2025-08-20 10:17:08 +02:00
bb62acfc7f feat: add secondary agegroup selector for subgroup filtering
- Added subgroup dropdown selector to filter events by team within agegroup
- Implemented logic to populate subgroup options based on selected agegroup
- Updated event filtering to support both agegroup and subgroup criteria
- Added event listeners for real-time filtering when selectors change
2025-08-20 10:17:00 +02:00
5f6ae79bf0 chore: bump version to v0.5.5 2025-08-19 19:22:21 +02:00
697788c20f feat: auto-load events on login and improve player display in event details
- Automatically load events when user logs in
- Rename updateAccountOptions to updateAccountOptionsAndLoadEvents
- Add auto-fetch of events after account selection
- Enhance event details modal with:
  * Player count summary
  * Position breakdown
  * Players sorted by position first, then by number
  * Position displayed in player list
2025-08-19 19:21:50 +02:00
5c5828cfc1 chore: add event title 2025-08-19 19:12:45 +02:00
0a88217443 chore: bump version to v0.5.4 2025-08-19 19:06:47 +02:00
2d783778a7 feat: update agegroup filter to show only agegroup and filter accordingly 2025-08-19 19:06:24 +02:00
3 changed files with 150 additions and 33 deletions

View File

@@ -3,7 +3,6 @@
## Build/Lint/Test Commands ## Build/Lint/Test Commands
### Setup ### Setup
```bash ```bash
# Install dependencies with Poetry # Install dependencies with Poetry
poetry install poetry install
@@ -13,7 +12,6 @@ pre-commit install
``` ```
### Linting and Formatting ### Linting and Formatting
```bash ```bash
# Run all pre-commit checks (linting, formatting, type checking) # Run all pre-commit checks (linting, formatting, type checking)
pre-commit run --all-files pre-commit run --all-files
@@ -26,52 +24,70 @@ yamllint . # YAML linting
markdownlint . # Markdown linting markdownlint . # Markdown linting
``` ```
### Testing ### Running Tests
```bash ```bash
# Run tests (no specific test framework configured) # No formal test framework configured
# Project uses manual testing with example PDF files in repository # Project uses manual testing with example PDF files in repository
# To test individual functions, run the CLI commands directly:
# myice schedule --days 7
# myice mobile-login
# myice search --help
```
### Running the Web API
```bash
# Or with poetry
poetry run fastapi run myice/webapi.py --host 127.0.0.1
``` ```
## Code Style Guidelines ## Code Style Guidelines
### Imports ### Imports
- Standard library imports first, then third-party, then local imports - Standard library imports first, then third-party, then local imports
- Use explicit imports rather than wildcard imports - Use explicit imports rather than wildcard imports
- Group imports logically with blank lines between groups - Group imports logically with blank lines between groups
### Formatting ### Formatting
- Use ruff-format for automatic formatting - Use ruff-format for automatic formatting
- Follow PEP 8 style guide - Follow PEP 8 style guide
- Maximum line length: 88 characters (default ruff setting) - Maximum line length: 88 characters (default ruff setting)
- Use 4 spaces for indentation - Use 4 spaces for indentation
### Types ### Types
- Use type hints for function parameters and return values - Use type hints for function parameters and return values
- Prefer built-in types (str, int, list, dict) over typing aliases when possible - Prefer built-in types (str, int, list, dict) over typing aliases when possible
- Use typing.Annotated for Typer command options - Use typing.Annotated for Typer command options
### Naming Conventions ### Naming Conventions
- Variables and functions: snake_case - Variables and functions: snake_case
- Classes: PascalCase - Classes: PascalCase
- Constants: UPPER_SNAKE_CASE - Constants: UPPER_SNAKE_CASE
- Private members: prefixed with underscore (_private) - Private members: prefixed with underscore (_private)
### Error Handling ### Error Handling
- Use try/except blocks for expected exceptions - Use try/except blocks for expected exceptions
- Raise appropriate HTTPException for API errors - Raise appropriate HTTPException for API errors
- Include descriptive error messages - Include descriptive error messages
- Use sys.exit(1) for command-line tool errors - Use sys.exit(1) for command-line tool errors
### Frameworks and Libraries ### Frameworks and Libraries
- Typer for CLI interface - Typer for CLI interface
- FastAPI for web API - FastAPI for web API
- requests for HTTP requests - requests for HTTP requests
- PyPDF2 for PDF processing - PyPDF2 for PDF processing
- Use rich for enhanced console output - Use rich for enhanced console output
- Custom rl_ai_tools package for AI functionalities
### Git Commit Messages
- Use conventional commits format
- Never mention Claude in commit messages
- Be descriptive but concise
- Use present tense ("add feature" not "added feature")
### Additional Rules
- Always use ddg-mcp to perform Web Search functionality
- Follow the existing code patterns in myice/myice.py and myice/webapi.py
- Maintain backward compatibility when modifying existing APIs
- Document new features in README.md
- Always run ruff format and ruff check after editing a python file
- use conventional commit messages

View File

@@ -32,16 +32,28 @@
<div class="container mt-2" id="mainContent" style="display: none;"> <div class="container mt-2" id="mainContent" style="display: none;">
<div id="eventFilters" style="display: none;"> <div id="eventFilters" style="display: none;">
<div class="mb-3"> <div class="mb-3 row">
<label for="account" class="form-label">Compte</label> <div class="col-md-3">
<select id="account" class="form-select"> <label for="account" class="form-label">Compte</label>
<option value="default">Défaut</option> <select id="account" class="form-select">
</select> <option value="default">Défaut</option>
<label for="agegroup" class="form-label">Âge</label> </select>
<select id="agegroup" class="form-select"> </div>
<option value="">Tous</option> <div class="col-md-3">
</select> <label for="agegroup" class="form-label">Âge</label>
<button id="fetchEvents" class="btn btn-primary" style="margin-top: 1.2rem;">Charger</button> <select id="agegroup" class="form-select">
<option value="">Tous</option>
</select>
</div>
<div class="col-md-3">
<label for="subgroup" class="form-label">Sous-groupe</label>
<select id="subgroup" class="form-select">
<option value="">Tous</option>
</select>
</div>
<div class="col-md-3 d-flex align-items-end">
<button id="fetchEvents" class="btn btn-primary">Charger</button>
</div>
</div> </div>
</div> </div>
@@ -77,6 +89,7 @@
const eventFilters = document.getElementById("eventFilters"); const eventFilters = document.getElementById("eventFilters");
const accountSelect = document.getElementById("account"); const accountSelect = document.getElementById("account");
const agegroupSelect = document.getElementById("agegroup"); const agegroupSelect = document.getElementById("agegroup");
const subgroupSelect = document.getElementById("subgroup");
const eventList = document.getElementById("eventList"); const eventList = document.getElementById("eventList");
const fetchButton = document.getElementById("fetchEvents"); const fetchButton = document.getElementById("fetchEvents");
const eventDetailsContent = document.getElementById("eventDetailsContent"); const eventDetailsContent = document.getElementById("eventDetailsContent");
@@ -210,9 +223,7 @@
} }
eventFilters.style.display = "block"; eventFilters.style.display = "block";
updateAccountOptions(); updateAccountOptionsAndLoadEvents();
// Don't automatically fetch events on page load
// Wait for user to explicitly select an account or click fetch
} else { } else {
// User is not logged in // User is not logged in
loginView.style.display = "flex"; loginView.style.display = "flex";
@@ -255,7 +266,7 @@
location.reload(); location.reload();
} }
function updateAccountOptions() { function updateAccountOptionsAndLoadEvents() {
// Fetch available accounts from the server // Fetch available accounts from the server
fetch(`${apiBaseUrl}/accounts`, { fetch(`${apiBaseUrl}/accounts`, {
headers: { "Authorization": `Bearer ${storedApiKey}` } headers: { "Authorization": `Bearer ${storedApiKey}` }
@@ -306,6 +317,9 @@
// Set the selected account in the dropdown // Set the selected account in the dropdown
accountSelect.value = accountToSelect; accountSelect.value = accountToSelect;
// Automatically fetch events for the selected account
fetchEvents(storedApiKey, accountToSelect);
}) })
.catch(error => { .catch(error => {
console.error("Erreur lors du chargement des comptes:", error); console.error("Erreur lors du chargement des comptes:", error);
@@ -334,6 +348,12 @@
}); });
agegroupSelect.addEventListener("change", () => { agegroupSelect.addEventListener("change", () => {
// Update subgroup options based on selected agegroup
updateSubgroupOptions(agegroupSelect.value, lastFetchedEvents);
displayEvents(lastFetchedEvents);
});
subgroupSelect.addEventListener("change", () => {
displayEvents(lastFetchedEvents); displayEvents(lastFetchedEvents);
}); });
@@ -404,20 +424,69 @@
} }
function updateAgeGroupOptions(events) { function updateAgeGroupOptions(events) {
let agegroups = new Set(events.map(event => `${event.agegroup} ${event.name}`.trim())); let agegroups = new Set(events.map(event => event.agegroup));
agegroupSelect.innerHTML = '<option value="">Tous</option>'; agegroupSelect.innerHTML = '<option value="">Tous</option>';
agegroups.forEach(group => { Array.from(agegroups).sort().forEach(group => {
const option = document.createElement("option"); const option = document.createElement("option");
option.value = group; option.value = group;
option.textContent = group; option.textContent = group;
agegroupSelect.appendChild(option); agegroupSelect.appendChild(option);
}); });
// Reset subgroup selector
subgroupSelect.innerHTML = '<option value="">Tous</option>';
}
function updateSubgroupOptions(selectedAgegroup, events) {
// Reset subgroup options
subgroupSelect.innerHTML = '<option value="">Tous</option>';
if (selectedAgegroup === "") {
// If no agegroup is selected, disable subgroup selector
subgroupSelect.disabled = true;
return;
}
// Enable subgroup selector
subgroupSelect.disabled = false;
// Extract subgroups from events matching the selected agegroup
let subgroups = new Set();
events
.filter(event => event.agegroup === selectedAgegroup)
.forEach(event => {
// Extract subgroup from event.name or event.title
// This assumes the subgroup is part of the name field
if (event.name && event.name !== selectedAgegroup) {
subgroups.add(event.name);
}
});
// Add subgroups to the selector
Array.from(subgroups).sort().forEach(subgroup => {
const option = document.createElement("option");
option.value = subgroup;
option.textContent = subgroup;
subgroupSelect.appendChild(option);
});
} }
function displayEvents(events) { function displayEvents(events) {
eventList.innerHTML = ""; eventList.innerHTML = "";
let selectedAgegroup = agegroupSelect.value; let selectedAgegroup = agegroupSelect.value;
let filteredEvents = events.filter(event => event.event === "Jeu" && (selectedAgegroup === "" || `${event.agegroup} ${event.name}` === selectedAgegroup)); let selectedSubgroup = subgroupSelect.value;
let filteredEvents = events.filter(event => {
// Filter by event type
if (event.event !== "Jeu") return false;
// Filter by agegroup
if (selectedAgegroup !== "" && event.agegroup !== selectedAgegroup) return false;
// Filter by subgroup
if (selectedSubgroup !== "" && event.name !== selectedSubgroup) return false;
return true;
});
if (filteredEvents.length === 0) { if (filteredEvents.length === 0) {
eventList.innerHTML = "<p class='text-muted'>Aucun événement 'Jeu' trouvé.</p>"; eventList.innerHTML = "<p class='text-muted'>Aucun événement 'Jeu' trouvé.</p>";
@@ -430,7 +499,9 @@
eventCard.innerHTML = ` eventCard.innerHTML = `
<div class="card" style="border-left: 5px solid ${event.color}" data-id="${event.id_event}"> <div class="card" style="border-left: 5px solid ${event.color}" data-id="${event.id_event}">
<div class="card-body"> <div class="card-body">
<h5 class="card-title">${event.title}</h5> <h5 class="card-title">${event.agegroup} - ${event.name}</h5>
<p class="card-text">${event.title}</p>
<p class="card-text"><strong>Adversaire:</strong> ${event.opponent}</p>
<p class="card-text"><strong>Lieu:</strong> ${event.place}</p> <p class="card-text"><strong>Lieu:</strong> ${event.place}</p>
<p class="card-text"><strong>Heure:</strong> ${event.start} - ${event.end}</p> <p class="card-text"><strong>Heure:</strong> ${event.start} - ${event.end}</p>
</div> </div>
@@ -451,16 +522,46 @@
const sortedPlayers = data.convocation.available const sortedPlayers = data.convocation.available
.sort((a, b) => (a.number || 0) - (b.number || 0)); .sort((a, b) => (a.number || 0) - (b.number || 0));
// Calculate player statistics
const totalPlayers = sortedPlayers.length;
const positionCount = {};
sortedPlayers.forEach(player => {
const position = player.position || "N/A";
positionCount[position] = (positionCount[position] || 0) + 1;
});
// Generate position breakdown
const positionBreakdown = Object.entries(positionCount)
.map(([position, count]) => `${position}: ${count}`)
.join(', ');
// Sort players by position first, then by number
const playersByPosition = [...sortedPlayers].sort((a, b) => {
// Sort by position first
const positionA = a.position || "ZZZ"; // Put undefined positions at the end
const positionB = b.position || "ZZZ";
if (positionA !== positionB) {
return positionA.localeCompare(positionB);
}
// If positions are the same, sort by number
const numA = parseInt(a.number) || 0;
const numB = parseInt(b.number) || 0;
return numA - numB;
});
eventDetailsContent.innerHTML = ` eventDetailsContent.innerHTML = `
<h5>${data.title}</h5> <h5>${data.title}</h5>
<p><strong>Type:</strong> ${data.type}</p> <p><strong>Type:</strong> ${data.type}</p>
<p><strong>Lieu:</strong> ${data.place}</p> <p><strong>Lieu:</strong> ${data.place}</p>
<p><strong>Heure:</strong> ${data.time_start} - ${data.time_end}</p> <p><strong>Heure:</strong> ${data.time_start} - ${data.time_end}</p>
<h6>Joueurs convoqués:</h6> <p><strong>Joueurs convoqués:</strong> ${totalPlayers} joueur${totalPlayers > 1 ? 's' : ''} (${positionBreakdown})</p>
<ul>${sortedPlayers.map(player => { <h6>Liste des joueurs:</h6>
<ul>${playersByPosition.map(player => {
let number = player.number ? player.number : "N/A"; let number = player.number ? player.number : "N/A";
let position = player.position ? player.position : "N/A"; let position = player.position ? player.position : "N/A";
return `<li>${number} - ${player.fname} ${player.lname} (${position}, ${player.dob})</li>`; return `<li>[${position}] ${number} - ${player.fname} ${player.lname} (${player.dob})</li>`;
}).join('')}</ul> }).join('')}</ul>
`; `;
new bootstrap.Modal(document.getElementById('eventDetailsModal')).show(); new bootstrap.Modal(document.getElementById('eventDetailsModal')).show();

View File

@@ -1,6 +1,6 @@
[project] [project]
name = "myice" name = "myice"
version = "v0.5.3" version = "v0.5.7"
description = "myice parsing" description = "myice parsing"
authors = [ authors = [
{ name = "Rene Luria", "email" = "<rene@luria.ch>"}, { name = "Rene Luria", "email" = "<rene@luria.ch>"},